fix(ssr): update wire adapter validation @ W-17274788 #4910
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wjhsf
commented
Nov 21, 2024
| const { decorators } = node; | ||
|
|
||
| if (decorators.length > 1) { | ||
| throw new Error('todo - multiple decorators at once'); |
There was a problem hiding this comment.
TODO: Fix these error messages.
wjhsf
commented
Nov 21, 2024
| path: NodePath<PropertyDefinition | MethodDefinition> | ||
| ): asserts config is NoSpreadObjectExpression { | ||
| if (!is.objectExpression(config)) { | ||
| throw new Error('todo - CONFIG_OBJECT_SHOULD_BE_SECOND_PARAMETER'); |
There was a problem hiding this comment.
TODO: add fixtures validating all the error messages
ekashida
approved these changes
Nov 21, 2024
nolanlawson
reviewed
Nov 21, 2024
| throw new Error('Invalid config provided to @wire decorator; expected an object literal.'); | ||
| for (const property of config.properties) { | ||
| // Only validate computed object properties because static props are all valid | ||
| // and we ignore {...spreads} and {methods(){}} |
There was a problem hiding this comment.
TODO: add a test for spreads.
nolanlawson
reviewed
Nov 21, 2024
| __connectContext(${/*wire adapter constructor*/ 0}, instance, (newContextValue) => { | ||
| const wireConfigObj = ${/*mapping from lwc fields to wire config keys*/ 2}; | ||
| wireInstance.update(wireConfigObj, newContextValue); | ||
| wireInstance.update(getLiveConfig(), newContextValue); |
There was a problem hiding this comment.
TODO: add a test for this being two different live values across two updates, to ensure in the future we don't mistakenly just set the variable once.
nolanlawson
approved these changes
Nov 21, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
The original wire adapter implementation made some incorrect assumptions (e.g. all values look like
"$string"); this PR updates the logic to better matchengine-server.Does this pull request introduce a breaking change?
Does this pull request introduce an observable change?
GUS work item